ref: Rename OOM to Watchdog Terminations #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c6fb5a9 | 1194.80 ms | 1232.68 ms | 37.88 ms |
| 010583c | 1198.23 ms | 1225.52 ms | 27.29 ms |
| a9e77dc | 1231.94 ms | 1254.85 ms | 22.91 ms |
| f91714d | 1222.06 ms | 1247.00 ms | 24.94 ms |
| d446105 | 1237.06 ms | 1261.34 ms | 24.28 ms |
| 2ae7db9 | 1231.37 ms | 1239.98 ms | 8.61 ms |
| ffa889e | 1229.37 ms | 1253.38 ms | 24.01 ms |
| 8361c4c | 1204.07 ms | 1252.74 ms | 48.67 ms |
| 4dc66f6 | 1202.59 ms | 1228.34 ms | 25.75 ms |
| 9be1db2 | 1219.42 ms | 1245.66 ms | 26.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c6fb5a9 | 20.75 KiB | 383.76 KiB | 363.01 KiB |
| 010583c | 20.75 KiB | 383.61 KiB | 362.85 KiB |
| a9e77dc | 20.75 KiB | 379.12 KiB | 358.36 KiB |
| f91714d | 20.75 KiB | 381.87 KiB | 361.12 KiB |
| d446105 | 20.75 KiB | 383.37 KiB | 362.62 KiB |
| 2ae7db9 | 20.75 KiB | 381.87 KiB | 361.12 KiB |
| ffa889e | 20.75 KiB | 383.83 KiB | 363.08 KiB |
| 8361c4c | 20.75 KiB | 383.87 KiB | 363.12 KiB |
| 4dc66f6 | 20.75 KiB | 381.81 KiB | 361.06 KiB |
| 9be1db2 | 20.75 KiB | 373.94 KiB | 353.19 KiB |
kevinrenskers
requested review from
philipphofmann,
brustolin and
armcknight
as code owners
kevinrenskers
commented
Dec 6, 2022
| */ | ||
| @property (nonatomic, assign) BOOL enableOutOfMemoryTracking; | ||
| @property (nonatomic, assign) BOOL enableWatchdogTerminationsTracking; |
There was a problem hiding this comment.
enableWatchdogTerminationsTracking or enableWatchdogTerminationTracking, not 100% sure which is better.
There was a problem hiding this comment.
I prefer enableWatchdogTerminationTracking
There was a problem hiding this comment.
I would have also preferred enableWatchdogTerminationTracking
There was a problem hiding this comment.
PR is now open with that change.
There was a problem hiding this comment.
Thank you @kevinrenskers 😀
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2499 +/- ##
==========================================
- Coverage 78.44% 78.42% -0.03%
==========================================
Files 242 241 -1
Lines 22282 22275 -7
Branches 9839 9835 -4
==========================================
- Hits 17479 17469 -10
- Misses 4351 4354 +3
Partials 452 452
Continue to review full report at Codecov.
|
kevinrenskers
changed the title
kevinrenskers
changed the title
|
The codecov step is resulting in a red cross: Is that really worth an error? 🤔 |
|
Note to self: sentry-docs needs to be updated. |
|
Docs PR: getsentry/sentry-docs#5938. I think we can merge this one? Waiting for approval. |
brustolin
approved these changes
Dec 12, 2022
|
I am going to merge this now since it's been waiting for six days and I want to prevent merge conflicts since this touches a bunch of stuff. If we want to change the option name, I can follow up with another PR. |
kevinrenskers
added a commit
that referenced
this pull request
Dec 16, 2022
* 8.0.0: (31 commits) tests: Reenable testAddAndRemoveData (#2533) feat: support SENTRY_DSN environment var on macOS (#2534) Remove duplicate entry (#2532) fix: ARC issue for FileManager (#2525) feat: Add SwiftUI performance tracking (#2271) fix: Remove all permission checks (#2529) Remove the automatic `viewAppearing` span (#2511) Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526) fix: Don't add out of date context for crashes (#2523) ref: Rename isOOM to watchdog in Client (#2520) test: Fix disabled failing watchdog test (#2521) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516) Rename the watchdog option and integration (#2513) feat: Enable CaptureFailedRequests by default (#2507) test: Fix asserts for SentryCrashTestInstallation (#2500) meta: User interaction tracing enabled per default (#2506) ref: Rename OOM to Watchdog Terminations (#2499) feat: enableUserInteractionTracing is GA (#2503) build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505) perf: Don't attach headers for SentryNoOpSpan (#2498) ...
philipphofmann
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jan 10, 2023
OOM is now called watchdog terminations. See getsentry/sentry-cocoa#2499, which will be part of the 8.0.0 release of sentry-cocoa. Co-authored-by: Isabel <[email protected]> Co-authored-by: Philipp Hofmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename OOM to Watchdog Terminations. Basically a pretty simple search and replace without any functional changes.